-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clientv3/integration: test lease keepalive #4369
Conversation
LGTM. |
kresp := <-rc | ||
if kresp.ID != resp.ID { | ||
t.Errorf("ID = %x, want %x", kresp.ID, resp.ID) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test the channel closes on Close()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. will do.
can this test the ctx cancel logic too? |
@heyitsanthony I wanted. However the keepAlive ctx is unimplemented right now. I plan to implement and then test it as a whole. |
ok, fair enough |
@heyitsanthony fixed a bunch of small issues. PTAL. |
@@ -182,6 +187,10 @@ func (c *Client) retryConnection(oldConn *grpc.ClientConn, err error) (*grpc.Cli | |||
// connection is established. | |||
func dialEndpointList(c *Client) (*grpc.ClientConn, error) { | |||
var err error | |||
if len(c.Endpoints()) == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be better to put this in New
instead of checking in the retrydialer every redial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will do.
lgtm after fixing nits |
close in favor of #4382 |
/cc @heyitsanthony @gyuho